Add extension support for argument count to ScriptInstance
#89050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
reviewed
Mar 1, 2024
AThousandShips
force-pushed
the
the_angry_count_extended
branch
from
34731c7
to
3f8c51c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
AThousandShips
force-pushed
the
the_angry_count_extended
branch
from
3f8c51c
to
71ab820
Compare
|
The changes here look good to me! Once PR #87680 is merged, I'd be happy to approve this one :-) |
AThousandShips
force-pushed
the
the_angry_count_extended
branch
from
71ab820
to
0c19d0f
Compare
dsnopek
approved these changes
Mar 14, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from:
To aid with synchronizing extensions to the
GDExtensionScriptInstanceInfostruct, see there for details, only the latest commit is relevant for this